@override in _type_checker_internals.TypedDictFallback#14115
Closed
jorenham wants to merge 1 commit intopython:mainfrom
Closed
@override in _type_checker_internals.TypedDictFallback#14115jorenham wants to merge 1 commit intopython:mainfrom
@override in _type_checker_internals.TypedDictFallback#14115jorenham wants to merge 1 commit intopython:mainfrom
Conversation
Member
|
Hmm, we don't generally decorate methods with |
Contributor
Author
Yea I expected something like that, I just thought I'd give it a shot either way. Thanks for the review :) |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a bug in the pyright github action, the
_typeshed._type_checker_internalsmodule is being checked by pyright in the CI ofscipy-stubs. And apparently, was@overrideone some methods inTypedDictFallback, causing the CI to fail (see e.g. https://github.com/scipy/scipy-stubs/actions/runs/15169287965/job/42655058438?pr=521). And just to be clear, I don't consider this to be the fault of typeshed or anything. I just figured that I might as well add those@override's, for the sake of completeness I suppose 🤷.